Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise styled-components devDep to 5 for all packages #895

Closed
wants to merge 1 commit into from

Conversation

craigpalermo
Copy link
Collaborator

Resolves #710

Recreated #848 and applied the change to all packages. No changes to peerDependencies were required, it's all just bumps to devDeps.

@codecov-commenter
Copy link

codecov-commenter commented Jul 29, 2020

Codecov Report

Merging #895 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #895   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           52        52           
  Lines          521       521           
=========================================
  Hits           521       521           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c5bf57...6af4e30. Read the comment docs.

Copy link
Collaborator

@sdalonzo sdalonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is a good idea until we get apps to upgrade past v3

@craigpalermo craigpalermo marked this pull request as draft July 29, 2020 18:11
@pcln-james pcln-james deleted the styled-components-5-devdep branch December 29, 2020 22:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prepare for styled-components v5
3 participants