Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting height property to 1 causes styling bug #963

Open
craigpalermo opened this issue Nov 13, 2020 · 0 comments
Open

Setting height property to 1 causes styling bug #963

craigpalermo opened this issue Nov 13, 2020 · 0 comments

Comments

@craigpalermo
Copy link
Collaborator

craigpalermo commented Nov 13, 2020

Describe the bug
For any component that passes height through to styled-system, setting height={1} results in height: 1px;. This is the expected behavior, so rather than diverge from how styled-system handles height, we should add a runtime warning and update the documentation to better explain the actual behavior in this scenario.

Affected project(s) (e.g. pcln-design-system, pcln-modal, etc.)

  • pcln-design-system

Expected behavior
A clear and concise description of what you expected to happen.

Screenshots
dsr height 1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant