Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thread safety of resource optimizer plugin #147

Closed
JensDallmann opened this issue Aug 1, 2013 · 5 comments
Closed

Thread safety of resource optimizer plugin #147

JensDallmann opened this issue Aug 1, 2013 · 5 comments
Assignees
Milestone

Comments

@JensDallmann
Copy link

We want to use the resource optimizer plugin in parallel builds. This plugin is not explicitly marked as thread safe (or not thread safe). It would be nice if you could evaluate if this plugin is thread safe and mark it as thread safe (or not thread safe).
If it is not thread safe maybe you can give a statement if thread safety will come in a future release.
Best Regards,
Jens

@ghost ghost assigned ova2 Aug 9, 2013
@ova2
Copy link
Member

ova2 commented Aug 11, 2013

We use this plugin with Maven 3.x (and parallel builds) without problems. How can I mark this plugin as thread safe? Is it not automatically thread-safe when you use Maven 3.x? You are welcome to provide a patch if you have any. Feel free to send a pull request.

@JensDallmann
Copy link
Author

Hello,
Thanks for your fast reply.
I’ve send you a pull request. It’s just one simple line which can’t break the build. As far as I know parallel builds were not supported in Maven 2.
Maven 3 allows parallel builds but can’t guarantee that every plugin is executed thread safe.
Developers have to check manually if the plugin is thread safe and mark it to prevent a warning in parallel builds.
I think it’s really hard to evaluate if a plugin is really thread safe but nice to hear that you use it in a parallel build and everything works fine!
Best Regards,
Jens

@ova2
Copy link
Member

ova2 commented Aug 12, 2013

Thanks Jens. I've merged your pull request.

@ova2 ova2 closed this as completed Aug 12, 2013
@ova2
Copy link
Member

ova2 commented Aug 12, 2013

FYI: I updated dependencies (#150) and released a new version 1.0.0 of this plugin today.

@JensDallmann
Copy link
Author

Thank you very much. J

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants