Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AjaxErrorHandler in Extensions 3.1.0 doesn't work with PF 5.2 #327

Closed
ova2 opened this issue May 3, 2015 · 6 comments
Closed

AjaxErrorHandler in Extensions 3.1.0 doesn't work with PF 5.2 #327

ova2 opened this issue May 3, 2015 · 6 comments
Assignees
Labels
Milestone

Comments

@ova2
Copy link
Member

ova2 commented May 3, 2015

Thomas, can you look into this? It is reproducable in every example. The dialog doesn't appear. Furthermore, I think buttonOnclick="ajaxErrorHandler.hide();" in examples should be rewritten as buttonOnclick="PF('ajaxErrorHandler').hide();".

By the way, should we maybe remove this component in favor of the PrimeFaces' ExceptionHandler?

I would remove some old components from Extensions in the next major release.

@ova2 ova2 added the bug label May 3, 2015
@ova2 ova2 added this to the 3.2.0 milestone May 3, 2015
@tandraschko
Copy link
Member

If pavol doesn't like to maintain it anymore, we should just remove it.
I really don't have much time and i will not invest it in components i've never used.

@tandraschko tandraschko assigned slany and unassigned tandraschko May 3, 2015
@ova2
Copy link
Member Author

ova2 commented May 3, 2015

Ok, I will remove it then if Pavol will not fix this issue in the next weeks.

@ova2 ova2 assigned ova2 and unassigned slany May 30, 2015
@ova2
Copy link
Member Author

ova2 commented May 30, 2015

Done. The AjaxErrorHandler removed.

Added PrimeExceptionHandlerFactory and PrimeExceptionHandlerELResolver to the showcase in order to use the PrimeFaces' ExceptionHandler.

@ova2 ova2 closed this as completed May 30, 2015
@Species8372
Copy link

I am currently migrating from an older primefaces-extensions Version.
I didnt find the removal of this feature anywhere, are there release-notes?
Also i am quite concerned that tandraschko is using all other features of this library, else he would remove them when they are having a bug?!

@ova2
Copy link
Member Author

ova2 commented Jul 2, 2015

@tandraschko
Copy link
Member

@Species8372
It's not my fault if there is no active community to fix bugs.
Pavol isn't active since many many months and there is a ExpceptionHandler available in PF core.
There is no reason for me or oleg to spend time to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants