Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline component not working in tabview #35

Closed
tandraschko opened this issue Jan 11, 2013 · 8 comments
Closed

Timeline component not working in tabview #35

tandraschko opened this issue Jan 11, 2013 · 8 comments
Assignees
Labels
Milestone

Comments

@tandraschko
Copy link
Member

http://code.google.com/p/primefaces-extensions/issues/detail?id=330

@nileshmali
We already have the hidden logic in ckeditor and codemirror. Maybe we can move this logic to core and use in this components.
Just contanct me when you plan to fix this.

@ghost ghost assigned nileshmali Jan 11, 2013
@ova2
Copy link
Member

ova2 commented Jan 11, 2013

I also have this logic in my components! For instance, in Layout (element layout).

@nileshmali
Copy link

I will try to resolve this today.

@ova2
Copy link
Member

ova2 commented Jan 25, 2013

If you need any help, send me an e-mail. By the way, I described this problem and solution in this chapter http://www.packtpub.com/sites/default/files/downloads/9281OS_Chapter_11_Writing_Custom_Components.pdf

@tandraschko
Copy link
Member Author

Hey guys,
I added the logic to core.js. Please see my last commit.

@oleg
If it's ok for you, please refactor your widget to use this method.

@ova2
Copy link
Member

ova2 commented Jan 25, 2013

Looks good Thomas. But why do we need checks with widget.widgetInitialized? Can it be not synchronized? JavaScript is one thread language, Thomas. This is unlike Java where we need to synchronize calls.

@tandraschko
Copy link
Member Author

What is if you switch tab and open the tab again? I think it will be called again.

@ova2
Copy link
Member

ova2 commented Jan 25, 2013

I don't know. The original logic didn't contain this. Ok. I will refactor my widgets.

@ova2
Copy link
Member

ova2 commented Jan 25, 2013

I left layout widget unchanged because I use this.jqTarget.is(':visible') and not this.jq

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants