DynaForm validation of the first control doesn't work when V6.0 is used

[sweetcard]

In the following demo, the validation of the first control doesn't work.
The back bean can't get value of the first control either.

The demo link is here:
http://www.primefaces.org/showcase-ext/sections/dynaform/basicUsage.jsf

[Rapster]

The demo uses PE 3.2 and validation works just fine. By the way @ova2, is it possible to deploy the new showcase?

Anyway, I just tried with PE 6.0.0 and it works fine as well. Did you see that error on showcase or personal use?

[sweetcard]

Thank you for your reply.
I found the error in my project not on showcase.
The same code in my project works with PE 5.3 but doesn't work with PE 6.0.0.
I haven't found any error log or output.
Just change the version from 6.0.0 to 4.0.0. It works.

<dependency> <groupId>org.primefaces.extensions</groupId> <artifactId>primefaces-extensions</artifactId> <version>4.0.0</version> </dependency>

[ova2]

I can not deploy the new showcase. This does Cagatay Civice, the PrimeFaces lead. I sent him the new WAR a long time ago, but they want to port the Timeline examples from the "old" showcase first.

[ryan-bennett]

I can confirm this issue as well in my project. The first input in the dynaform does not have it's value set nor is validated. The same input, when moved to another position is validated correctly.

Workaround, add a control that resolves to a hidden input prior to the first input.

PrimeFaces 6.0.1
PrimeFaces Extensions 6.0.0

[sweetcard]

@ryan-bennett
The showcase checked out from git can't work either.
I spent hours to solve it but failed.
:(

[ryan-bennett]

HI Sweetcard

To work around this, add a dynaform section with a dummy type at the start of your model e.g.

Java

DynaFormModel dynaFormModel = new DynaFormModel();
DynaFormRow dummyRow = dynaFormModel.createRegularRow();
dummyRow.addControl(new Field().label(""), "dynaform_dummy", 2, 1);

JSF

<pe:dynaFormControl type="dynaform_dummy">
    <h:inputHidden />
</pe:dynaFormControl>

[sweetcard]

@ryan-bennett
That's COOOOL!
It works for me.
You save me some days.
Thank you very much.
I hope the issue could be fixed soon.
Thank you again.

[ryan-bennett]

Glad it helped.

[Rapster]

Am I wrong to say DynaForm works fine in the current online showcase? It's hard to believe the contrary... The only difference I'd see would be PF version you guys are using. Although, I raised an issue which might be related of what you're talking: http://forum.primefaces.org/viewtopic.php?f=14&t=46195&p=144038#p144038

Is your first input a composite or a basic input?

[sweetcard]

@Rapster
The showcase checked out from github does't work.
When submit is clicked, the validation message is not correct.
Check the attachment please.

[Rapster]

I did reproduce the problem with the current branch. I'll check that as soon as I have some time to do so

[sweetcard]

@Rapster
Excellent 💯 👍

[ova2]

@Rapster When you fixed this issue (regression), I will release the current state. One of my clients uses this component and will find this issue too. That's for sure :-).

Thanks for your effort!

[Rapster]

I might need your help Oleg on this one... There is a lot of things in this component that I don't simply understand as the mechanic is quite complex :/

[ova2]

Saidly, but I don't have any time currently and I don't do much JSF development. More JavaScript. Please try to follow your last changes. The component worked fine bevor 6.0 release. Thanks.

[Rapster]

Yes I know, since I did modification #384 there is few bugs regarding validation... and probably few other. I'll do my best but I'm still curious how many components are present in the JSF component tree. For example, if I take this example http://www.primefaces.org/showcase-ext/sections/dynaform/basicUsage.jsf, the number of component added is equal to the number of dynaFormControl?

[Rapster]

@sweetcard could you check again ? I just push a fix. It should work. Although There is still a problem only if you're using DynaForm inside a iterator component such as ui:repeat. In case validation fails, clientId is displayed instead of label value only the first time form is submitted...

[sweetcard]

@Rapster It works now.
That's very cool.
Thanks for your excellent work. 👍

[Rapster]

Cool. @ova2 you can make a new release now ;)

[ova2]

@Rapster you are hero :-) Should we release 6.0.1? @tandraschko what do you mean? I could remove Spotlight and you can remove TriStateCheckbox and we're done.

[tandraschko]

+1 for the release
but i would just do the bugfixes and lets remove the duplicate components for 6.1
if we do a 6.0.1, a user don't expect that we remove components

[ova2]

Ok, we should remove the components for 6.1 and not now due to PF public release 6.1 (Spotlight can be removed anyway). For now I can do a release this week. Only Extensions core and CKEditor. Is it ok for you?