Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sheet: New column type "button" #136

Closed
ssibitz opened this issue Apr 12, 2018 · 3 comments
Closed

Sheet: New column type "button" #136

ssibitz opened this issue Apr 12, 2018 · 3 comments
Labels
enhancement Improve an existing component

Comments

@ssibitz
Copy link

ssibitz commented Apr 12, 2018

In the newest component "Sheet" i am missing a ColType for handling button-actions
like Delete Row, Mark Row and so on.

I will eventually need this for our project because in the showcase
the example for using it with right-click is nice,
but not useable on e.g. a touch-screen
or a user who don't know how to use the right-click ;-)

Here would it always be better to support a button with a minimum height of
about 39px, a icon (font awesome if possible) and a listener or onclick .

@melloware melloware self-assigned this Apr 12, 2018
@melloware melloware changed the title Missing ColType "button" in the new component "Sheet" Sheet: New column type "button" Apr 12, 2018
@ssibitz
Copy link
Author

ssibitz commented Apr 13, 2018

What do you think about the new "feature" with a button inside the sheet ?

I currently switched from DataTable to the Sheet-Component
because the DataTable has a lot of issues in combination with editing/inserting
and generating a lot of datas.
The sheet component does not and only send the datas needed to the server via AJAX.
So i compared the 2 components and with the same datas inside and displaying
the Primefaces Datatable tries to send about 1000 datas via url when changing a row
but the sheet only sends about 10 datas which is on and needed :-)
Also the Primefaces Datatable crashes if you try to send over 1000 datas
which can be a simple table with 10 columns and 50 rows ...

@melloware
Copy link
Member

I like the idea of a button cell. Just have to figure out how to implement. Looks like I will have to use HTML cell type...

https://stackoverflow.com/questions/24774811/how-do-i-add-a-custom-button-inside-a-cell-in-handsontable/24777491

And all the reasons you stated above is why we built the sheet component because we had similar requirements to yours and with Datatable would run into Form parameters limits etc.

@melloware melloware transferred this issue from primefaces-extensions/primefaces-extensions.github.com Aug 26, 2020
@melloware melloware transferred this issue from another repository Aug 27, 2020
@melloware melloware added the enhancement Improve an existing component label Aug 27, 2020
@melloware melloware removed their assignment Nov 24, 2020
@melloware
Copy link
Member

I am not planning on adding this. Will reopen if someone submits a PR down the road.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improve an existing component
Projects
None yet
Development

No branches or pull requests

2 participants