Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

firstDayOfWeek is broken in 11.3.1 #10013

Closed
WillooWisp opened this issue Mar 16, 2021 · 2 comments
Closed

firstDayOfWeek is broken in 11.3.1 #10013

WillooWisp opened this issue Mar 16, 2021 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@WillooWisp
Copy link

This works in 11.3.0, but not after upgrading to 11.3.1.

@denny99
Copy link
Contributor

denny99 commented Mar 17, 2021

image

image

It works when you change the order in your i18n data. But the code for the whole @input is still in place and even generates the correct weekDay array. But in the rendering process it just uses the i18n Data

@WillooWisp
Copy link
Author

WillooWisp commented Mar 17, 2021

I don't use the i18n data but rely on the firstDayOfWeek property that I bind to region settings.

<p-calendar [(ngModel)]="date" [firstDayOfWeek]="firstDayOfWeek" inline="true"

Works fine in 11.3.0 and earlier.

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Mar 17, 2021
@yigitfindikli yigitfindikli self-assigned this Mar 17, 2021
@WillooWisp WillooWisp reopened this Mar 17, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Mar 23, 2021
@yigitfindikli yigitfindikli added this to the 11.3.2 milestone Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants