Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when changing Button Icon #10138

Closed
denny99 opened this issue Apr 20, 2021 · 1 comment
Closed

Crash when changing Button Icon #10138

denny99 opened this issue Apr 20, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@denny99
Copy link
Contributor

denny99 commented Apr 20, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/github-5mkgtv?file=src/app/app.component.html

Current behavior
Using a button that has no icon initially fails as the Dom Element won't be generated but is tried to be update when chaning the icon on the fly.

Expected behavior
Buttons without any icon can get a new icon after rendering

What is the motivation / use case for changing the behavior?
In our use case, we wrapped the primeng buttons, disable them on click and show a progress spinner to avoid double clicks.

  • Angular version: 11.X

  • PrimeNG version: 11.3.1

  • Browser: [all]

  • Language: [TypeScript 4.2]

@yigitfindikli yigitfindikli added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 20, 2021
@yigitfindikli yigitfindikli self-assigned this Apr 21, 2021
@yigitfindikli yigitfindikli added this to the 11.4.0 milestone Apr 21, 2021
@yigitfindikli
Copy link
Member

Fixed in b037db9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants