Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-calendar styling is incorrect when it is disabled with an icon #10167

Closed
PeterHewat opened this issue Apr 27, 2021 · 1 comment
Closed

p-calendar styling is incorrect when it is disabled with an icon #10167

PeterHewat opened this issue Apr 27, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@PeterHewat
Copy link

#10024 was only partially fixed then closed hence I am opening a new issue to bring forward the remaining issue.

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Stackblitz Example
Previous bug #10024 in PrimeNG 11.3.0:
https://stackblitz.com/edit/primeng-issue-mdc-theme-calendar-with-icon-primeng-11-3-0?file=src%2Fapp%2Fapp.component.html

Partial fix in PrimeNG 11.4.0
https://stackblitz.com/edit/primeng-issue-mdc-theme-calendar-with-icon-primeng-11-4-0?file=src%2Fapp%2Fapp.component.html

Current behavior
The style of a disabled p-calendar with icon is incorrect
=> hovering over it changes it's style.
This doesn't occur if the calendar icon isn't displayed.

Expected behavior
The style of a disabled p-calendar should be correct, irrelevant of if it has an icon or not.

Minimal reproduction of the problem with instructions
See Stackblitz Example
Prerequisite: Use class p-input-filled & themes/mdc-light-indigo/theme.css.

  • Angular version: 11.2.11

  • PrimeNG version: 11.4.0

  • Browser: all

  • Language: all

@PeterHewat PeterHewat changed the title p-calendar styling is incorrect when it is disabled with an icon (partialy fixed) p-calendar styling is incorrect when it is disabled with an icon (partially fixed) Apr 27, 2021
@PeterHewat
Copy link
Author

Adding styleClass="p-disabled" to the disabled p-calendar as described in #10024 fixes this issue.

@yigitfindikli yigitfindikli self-assigned this Apr 27, 2021
@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Apr 27, 2021
@yigitfindikli yigitfindikli added this to the 11.4.1 milestone Apr 27, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Apr 27, 2021
@yigitfindikli yigitfindikli changed the title p-calendar styling is incorrect when it is disabled with an icon (partially fixed) p-calendar styling is incorrect when it is disabled with an icon Apr 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants