Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timeline Module missing module export #10205

Closed
Eastrall opened this issue May 6, 2021 · 0 comments
Closed

Timeline Module missing module export #10205

Eastrall opened this issue May 6, 2021 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Eastrall
Copy link

Eastrall commented May 6, 2021

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)

Reproduction case : https://stackblitz.com/edit/github-f6xfzg?file=src/app/app.component.ts

Current behavior

When importing the TimelineModule only, the content, opposite and marker can't be customized.

Expected behavior

The TimelineModule should be customizable.

What is the motivation / use case for changing the behavior?

I want to use the TimelineModule independently.

  • Angular version: 9.X but also tested on 11.X
  • PrimeNG version: 11.3.0-rc.1

Additionnal information

I went through the code of the TimelineModule and noticed that the module doens't exports SharedModule like other modules (eg. CardModule).
I followed the documentation and the sample code imports both TimelineModule and CardModule, which one of them exports SharedModule so we can use the pTemplate directive.

CardModule: https://github.com/primefaces/primeng/blob/master/src/app/components/card/card.ts#L104
TimelineModule: https://github.com/primefaces/primeng/blob/master/src/app/components/timeline/timeline.ts#L87

On the other hand, if you only want to import the TimelineModule, the pTemplate directive isn't recognized and the <ng-template> wont work properly.

I can open a PR to add the SharedModule export on the TimelineModule is you want.

@yigitfindikli yigitfindikli added Status: Pending Review Issue or pull request is being reviewed by Core Team Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 6, 2021
@yigitfindikli yigitfindikli self-assigned this May 6, 2021
@yigitfindikli yigitfindikli added this to the 11.4.1 milestone May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants