Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button icon css class not set after it has been initialized #10277

Closed
Kisters-BS opened this issue May 27, 2021 · 2 comments
Closed

Button icon css class not set after it has been initialized #10277

Kisters-BS opened this issue May 27, 2021 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Kisters-BS
Copy link
Contributor

I'm submitting a ...

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)

https://stackblitz.com/edit/github-akgkdp?file=src/app/app.component.html

Current behavior
Button with pButton directive and icon does not have css class ".p-button .p-button-icon-left" if the text is set after the button has been initialized without text. With the p-button it works as expected.

Expected behavior
The css class for the icon should be added if the button has text.

Minimal reproduction of the problem with instructions
Use button with pButton directive and icon. Set Text after it has been initialized.

What is the motivation / use case for changing the behavior?
I want to add the text for the button dynamically.

  • Angular version: 11.0.0

  • PrimeNG version: 11.3.0

  • Browser: [Chrome 91 | Firefox 88 | Edge 90]

  • Language: TypeScript 4.0.2

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 27, 2021
@yigitfindikli yigitfindikli added this to the 12.Future milestone May 27, 2021
@yigitfindikli yigitfindikli self-assigned this May 27, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Jun 7, 2021
@yigitfindikli yigitfindikli modified the milestones: 12.Future, 12.0.0-Final Jun 7, 2021
@Kisters-BS
Copy link
Contributor Author

Thank you very much!

@yigitfindikli
Copy link
Member

Thanks for the reporting :) @Kisters-BS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants