Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Textarea does not create new line when used in Datatable celleditor, instead completes edit mode #10458

Closed
ArohanGit opened this issue Jul 29, 2021 · 2 comments · Fixed by #11476
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@ArohanGit
Copy link

ArohanGit commented Jul 29, 2021

I'm submitting a bug report... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)
https://stackblitz.com/edit/github-ytaja5

Current behavior
Textarea when used in Datatable Celleditor completes Edit Mode when Enter Or ALT+Enter Or Shift+Enter key is pressed.

Expected behavior
When ALT+ENTER Or Shift+ENTER key is presssed new line should be added in Textarea and Edit mode should continue

  • Angular version: 11.X

  • PrimeNG version: 11.2.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Edge]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jul 29, 2021
@yigitfindikli yigitfindikli added this to the 12.Future milestone Jul 29, 2021
@yigitfindikli yigitfindikli self-assigned this Jul 29, 2021
@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@mertsincan mertsincan removed this from the 14.Future milestone Nov 9, 2022
@cetincakiroglu cetincakiroglu self-assigned this Mar 31, 2023
@cetincakiroglu cetincakiroglu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 31, 2023
@cetincakiroglu cetincakiroglu added this to the 15.3.1 milestone Mar 31, 2023
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 19, 2023
@ThibSCH
Copy link

ThibSCH commented May 26, 2023

Hi,
I ran into the same issue and can confirm that this is still not fixed in the latest version (16.0 rc1).
As shown here :
demo

@mertsincan mertsincan reopened this Aug 18, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 18, 2023
@mertsincan mertsincan removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants