Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Password and TreeSelect | Invalid styles are missing #10766

Closed
jiangyh1024 opened this issue Oct 25, 2021 · 1 comment
Closed

Password and TreeSelect | Invalid styles are missing #10766

jiangyh1024 opened this issue Oct 25, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jiangyh1024
Copy link

I think the style in theme.css is wrong

.p-password.p-invalid.p-component > .p-inputtext {
  border-color: someColor;
}

should be the following

p-password.ng-dirty.ng-invalid > .p-password > .p-inputtext {
  border-color: someColor;
}
p-password.ng-dirty.ng-invalid .p-inputtext:enabled:focus {
  box-shadow: inset 0 0 0 1px someColor,
    inset 0 0 0 1px someColor, inset 0 0 0 1px someColor,
    inset 0 0 0 1px someColor;
}
@jiangyh1024
Copy link
Author

jiangyh1024 commented Oct 25, 2021

otherwise, the border won't turn red for p-password

@yigitfindikli yigitfindikli added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Oct 25, 2021
@yigitfindikli yigitfindikli self-assigned this Oct 25, 2021
@yigitfindikli yigitfindikli added this to the 12.2.2 milestone Oct 25, 2021
@yigitfindikli yigitfindikli added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels Oct 27, 2021
@yigitfindikli yigitfindikli changed the title Missing styles for p-password if it is invalid (ng-invalid) Password and TreeSelect | Invalid styles are missing Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants