Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MegaMenu | RouterLink CtrlKey support #11049

Closed
waratah opened this issue Jan 10, 2022 · 0 comments
Closed

MegaMenu | RouterLink CtrlKey support #11049

waratah opened this issue Jan 10, 2022 · 0 comments
Assignees
Labels
LTS-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@waratah
Copy link
Contributor

waratah commented Jan 10, 2022

I'm submitting a ... (check one with "x")

[X ] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Current behavior
Clicking with CTRL pressed and a menu item on a mega menu panel will open a new page, however if you have no sub menus just one level a ctrl click on the menu bar does not open new page.

Expected behavior

new page

Minimal reproduction of the problem with instructions

Pull request is here.

#11006

Note that I have used ctrl click to ensure that event processing is stopped still. I have a problem with menu navigation cancelling http calls when I navigate too quickly from my first page.

What is the motivation / use case for changing the behavior?

My users open multiple pages at once for their work

  • Angular version: 13
  • PrimeNG version: 13
  • Browser: all
  • Language: TypeScript
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 12, 2022
@yigitfindikli yigitfindikli added this to the 13.0.5 milestone Jan 12, 2022
@yigitfindikli yigitfindikli self-assigned this Jan 12, 2022
@yigitfindikli yigitfindikli changed the title V13 - ctrl-click not openning new page on menu bar click (partial fix applied previously) MegaMenu | RouterLink CtrlKey support Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

2 participants