Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Dialog Ref crashes the App on close #11230

Closed
ghost opened this issue Feb 24, 2022 · 5 comments · Fixed by #12218
Closed

Dynamic Dialog Ref crashes the App on close #11230

ghost opened this issue Feb 24, 2022 · 5 comments · Fixed by #12218
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@ghost
Copy link

ghost commented Feb 24, 2022

I'm submitting a ...

[x] bug report
[ ] feature request
[ ] support request

Plunkr Case (Bug Reports)

Demo: https://github-xqz8yh.stackblitz.io

Current behavior

If you want to show a dialog until some action is done, the app will crash on dialog close.

Expected behavior

It should open a dialog for x amount of time and then close it without crashing the application.

Minimal reproduction of the problem with instructions

  • Open the demo above.
  • Click on the "Save Image" button.
  • Open the console and red an error

Please tell us about your environment:

  • OS: Windows 10

  • IDE: Visual Studio Code

  • Package manager: npm

  • Angular version: 13.X

  • PrimeNG version: 13.X
  • Browser: [all]
  • Language: [all]

  • Node (for AoT issues): node --version = 14.17.5

@cetincakiroglu
Copy link
Contributor

Hi,

I can't access the code of the example, could you please provide an editable Stackblitz link?

Regards

@ghost
Copy link
Author

ghost commented Mar 2, 2022

@mertsincan
Copy link
Member

Hi,

So sorry for the delayed response! Improvements have been made to many components recently, both in terms of performance and enhancement. Therefore, this improvement may have been developed in another issue ticket without realizing it. You can check this in the documentation. If there is no improvement on this, can you reopen the issue so we can include it in our roadmap?
Please don't forget to add your feedback as a comment after reopening the issue. These will be taken into account by us and will contribute to the development of this feature. Thanks a lot for your understanding!

Best Regards,

@ghost
Copy link
Author

ghost commented Nov 15, 2022

Hi @mertsincan ,

I have checked and apparently, the issue still persists.
I have created a PR for this one #12218

@mertsincan mertsincan reopened this Nov 15, 2022
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 15, 2022
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 15, 2022
@mertsincan mertsincan added this to the 14.2.2 milestone Nov 15, 2022
@davodbeheshti
Copy link

Hello, I also encountered the same problem in Angular version 12

When this.ref.close() command was executed in the dialog, the page was refresh automatically

And my problem was solved in such a way that inside the buttons that executed this command

I gave them the type "button" and my problem was solved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants