Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggleable panel inside another toggleable panel has it's content visible when collapsed by default #12713

Closed
creed-maxeta opened this issue Mar 6, 2023 · 1 comment · Fixed by #12721
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@creed-maxeta
Copy link
Contributor

creed-maxeta commented Mar 6, 2023

Describe the bug

When one toggleable panel has another toggleable panel inside, expanding the outer panel sets the content of the inner panel to be visible even though it is collapsed.

This is almost exactly the same issue as #11736
This may also relate to #12164

As mentioned in #11736 this issue pertains to panels, accordions, and panelmenus as well.
It was introduced in commit f849e9d
It appears this was fixed for fieldsets and potentially accordions. However, it is still present here.

Environment

Locally I am running Windows, Primeng 15 and Angular 15.
The stackblitz is utilizing primeng 14 and angular 14 as the issue fork defaults.

Reproducer

https://stackblitz.com/edit/github-trkcts-rca4nw?file=src/app/app.component.html

Angular version

15.2.1

PrimeNG version

15.2.0

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

18.4.2

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to https://stackblitz.com/edit/github-trkcts-rca4nw?file=src/app/app.component.html
  2. Expand first panel
  3. Second panel is collapsed and it's content is visible

Expected behavior

The content of second panel should be hidden when it is collapsed.

The problem is when toggleable panels are nested one inside another.

This css is wrong:

.p-panel-toggleable.p-panel-expanded .p-toggleable-content:not(.ng-animating) {
overflow: visible;
}

@creed-maxeta creed-maxeta added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 6, 2023
@creed-maxeta
Copy link
Contributor Author

#12721 PR submitted

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 21, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants