Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Panel: Collapse icon of toggle button is not showing #13071

Closed
miribo opened this issue May 20, 2023 · 1 comment
Closed

Panel: Collapse icon of toggle button is not showing #13071

miribo opened this issue May 20, 2023 · 1 comment
Labels
LTS-FIXED-15.4.4 Fixed in PrimeNG LTS 15.4.4 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@miribo
Copy link

miribo commented May 20, 2023

Describe the bug

In Panel component, collapse icon of toggle button is not showing when collapse icon property is defined in p-panel tag.
When panel is expanded, collapse icon of the toggle button is not shown.

Environment

Bug can be reproduced in primeng-panel-toggleable-demo on StackBlitz.

Reproducer

https://stackblitz.com/run?file=src%2Fapp%2Fdemo%2Fpanel-toggleable-demo.html

Angular version

16.0.0

PrimeNG version

16.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

Chrome 113

Steps to reproduce the behavior

Open file panel-toggleable-demo.html located in src\app\demo directory.
Add properties expandIcon and collapseIcon to p-panel tag like:
<p-panel header="Header" [toggleable]="true" expandIcon="pi pi-chevron-up" collapseIcon="pi pi-chevron-down">
Note: Icons are in reverse order as stated in issue #12929.
After demo is compiled panel is showed expanded but toggle button is not showing chevron-down icon.
Span element inside of toggle button (labeled as collapse button) is missing.
Expand icon is showed properly in toggle button (labeled as expand button).

This is not case when collapseIcon property is not defined (minus icon is shown in collapse button).

Expected behavior

When collapseIcon property of panel is defined, defined icon should be showed in togle button.

@miribo miribo added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 20, 2023
@cetincakiroglu cetincakiroglu added this to the 16.0.0 milestone May 22, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 22, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks for reporting the issue.
Fixed in #13074

@gucal gucal added LTS-FIXED-15.4.4 Fixed in PrimeNG LTS 15.4.4 and removed LTS-PORTABLE labels May 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-15.4.4 Fixed in PrimeNG LTS 15.4.4 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants