Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CascadeSelect: Wrong type definition for optionGroupChildren #13152

Closed
VCourdy opened this issue Jun 6, 2023 · 4 comments · Fixed by #13153
Closed

CascadeSelect: Wrong type definition for optionGroupChildren #13152

VCourdy opened this issue Jun 6, 2023 · 4 comments · Fixed by #13153
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@VCourdy
Copy link
Contributor

VCourdy commented Jun 6, 2023

Describe the bug

The type definition for the property "optionGroupChildren" of the component CascadeSelect is wrong on "16.0.0-rc.2".
Everything work just fine with "16.0.0-rc.1"

image

it look like the issue is linked to tsconfig "importHelpers".

Environment

WSL2 Debian 11
NodeJS 18.13.0

Reproducer

https://stackblitz.com/edit/github-dmcdmy-zzaurf

Angular version

16.0.0

PrimeNG version

16.0.0-rc.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.13.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@VCourdy VCourdy added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 6, 2023
@VCourdy VCourdy mentioned this issue Jun 6, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 12, 2023
@cetincakiroglu cetincakiroglu modified the milestones: 16.0.0, 16.0.1 Jun 12, 2023
@olegkap
Copy link

olegkap commented Jun 13, 2023

I have similar issue.

Here this property used to be defined as:
@Input() options: any[];:

But then in next commit it changed to
@Input() options: string[] | string | undefined | null;

So now if anybody who has setting "strictTemplates" is true it will be failing
maybe to change it to something like "unknown" instead of string or any

@cetincakiroglu cetincakiroglu linked a pull request Jun 16, 2023 that will close this issue
@cetincakiroglu cetincakiroglu modified the milestones: 16.0.1, 16.Future Jun 16, 2023
@cholasimmons
Copy link

cholasimmons commented Jun 28, 2023

yea I'm also trying to use a custom interface under the p-cascadeSelect's [options] attribute, but I'm being told only string[] | string | undefined are accepted

Angular 16.1.2, PrimeNG 16.0.2

@emeryao
Copy link

emeryao commented Jul 13, 2023

+1

still have the same issue here

@cholasimmons
Copy link

Until it's fixed, you can Ctrl+click (on Windows) on options and change string[] to any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants