Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimeNG Website - Documentation for Toast missing position feature in demo #13159

Closed
KraftyKaleb opened this issue Jun 7, 2023 · 1 comment · Fixed by #13179
Closed

PrimeNG Website - Documentation for Toast missing position feature in demo #13159

KraftyKaleb opened this issue Jun 7, 2023 · 1 comment · Fixed by #13179
Assignees
@gucal
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
16.0.0

Comments

@KraftyKaleb
Copy link

Describe the bug

https://primeng.org/toast#position
Demo code is missing the position HTML tag. It is possible to view the API tab and infer that the property should be in the HTML, but this may be confusing for new users.
image
Should be <p-toast position="{{position}}">

Environment

Chrome 114.0.5735.110

Reproducer

No response

Angular version

16.0.1

PrimeNG version

16.0.0-rc.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.0

Browser(s)

Chrome 114.0.5735.110

Steps to reproduce the behavior

Go to https://primeng.org/toast#position and view the code in the demo. There is no "position" property used.

Expected behavior

I expected the code demo to demonstrate how to use the documented feature.
@KraftyKaleb KraftyKaleb added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 7, 2023
@gucal gucal self-assigned this Jun 12, 2023
@gucal gucal added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jun 12, 2023
@gucal gucal added this to the 16.0.0 milestone Jun 12, 2023
@gucal gucal mentioned this issue Jun 12, 2023
Merged
@gucal
Copy link
Member

gucal commented Jun 12, 2023

Hi,

Thanks for reporting. Fixed #13179

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gucal gucal

Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
16.0.0
Development

Successfully merging a pull request may close this issue.

Fix 13159 - PrimeNG Website - Documentation for Toast missing positio… primefaces/primeng
2 participants
@KraftyKaleb @gucal