Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-menu: Links are turned into groups #13297

Closed
virtualmarc opened this issue Jul 6, 2023 · 5 comments · Fixed by #13378
Closed

p-menu: Links are turned into groups #13297

virtualmarc opened this issue Jul 6, 2023 · 5 comments · Fixed by #13378
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@virtualmarc
Copy link

Describe the bug

Top Level menu items from the model are turned from links to groups as soon as a group is added to the model.

If the model only contains url, routerLink or command Entries everything works fine, but as soon as a group entry with sub items is added, everything on the top level is turned to groups.

Environment

macOS 13.4
IntelliJ IDEA 20023.1.3

Reproducer

https://stackblitz.com/edit/8uujks?file=src%2Fapp%2Fdemo%2Fmenu-group-demo.ts

Angular version

16.0.0

PrimeNG version

16.0.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.16.1

Browser(s)

Chrome 114

Steps to reproduce the behavior

  1. Create a Menu Model
  2. Add the model to a p-menu
  3. Fill the Model with routerLink Entries
  4. Add an Entry with Child Entries

Expected behavior

Links should stay links and should not convert to groups.
This works fine with the Panel Menu but not with the Menu.

@virtualmarc virtualmarc added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 6, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

The issue is not clear and the reproducer you've shared is the actual example in the live demo which does not replicate the issue. Could you please share a valid Stackblitz reproducer?

@cetincakiroglu cetincakiroglu added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jul 10, 2023
@github-actions
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@virtualmarc
Copy link
Author

Sorry, StackBlitz did not save my changes I made to the example.

I updated the example again.

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels Jul 10, 2023
@cetincakiroglu cetincakiroglu self-assigned this Jul 10, 2023
@cetincakiroglu cetincakiroglu added this to the 16.0.3 milestone Jul 10, 2023
@cetincakiroglu
Copy link
Contributor

Hi,

Thanks for updating the example, now I can see the bug.

@SoyDiego
Copy link
Contributor

Hi @cetincakiroglu and @virtualmarc.
I did a PR #13313 solving the problem.
Let me know If I should modify something :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
4 participants