Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-steps Docs: Routing Example Broken #13519

Closed
kyjus25 opened this issue Aug 20, 2023 · 2 comments · Fixed by #13527
Closed

p-steps Docs: Routing Example Broken #13519

kyjus25 opened this issue Aug 20, 2023 · 2 comments · Fixed by #13527
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@kyjus25
Copy link
Contributor

kyjus25 commented Aug 20, 2023

Describe the bug

https://primeng.org/steps/seat#routing is missing the Next / Back buttons and should either be removed or fixed. Manually clicking the "Seats" step takes you to /seats, but going back to /personal either by clicking the step or by navigating in the URL does not work and returns a site-wide 404, which may be why the buttons were removed.

UPDATE: I also noted that the Algolia search defaults directly to https://primeng.org/steps/seat, this should be https://primeng.org/steps/personal

Screenshot 2023-08-20 at 2 12 17 PM

Environment

Chrome

Reproducer

https://primeng.org/steps/seat#routing

Angular version

16.0.0

PrimeNG version

16.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

Expected behavior

Demo works as on https://www.primefaces.org/primeng-v14-lts/steps/personal

@kyjus25 kyjus25 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 20, 2023
@SoyDiego
Copy link
Contributor

I'm on it.
This afternoon I will do the PR :)

@SoyDiego
Copy link
Contributor

The PR is here #13527.

Thanks for you help @kyjus25

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 26, 2023
@mertsincan mertsincan added this to the 16.2.1 milestone Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants