Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic change detection for charts #1352

Closed
cagataycivici opened this issue Nov 18, 2016 · 1 comment
Closed

Remove problematic change detection for charts #1352

cagataycivici opened this issue Nov 18, 2016 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@cagataycivici
Copy link
Member

Charts having multiple datasets break change detection and we could not find a decent way to do change detection for charts right now. Instead add reload() method to let the user do it manually.

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Nov 18, 2016
@cagataycivici cagataycivici added this to the 1.0.0 milestone Nov 18, 2016
@cagataycivici cagataycivici self-assigned this Nov 18, 2016
@chpasha
Copy link

chpasha commented Nov 28, 2016

I'm sorry, I must be missing something. The chart where working just fine, at least I could change the data reference and the chart was updating. It didn't work for multiple datasets? Ok, maybe, but it did for more common scenarios and with complex ones we could still call some update/refresh whatever. Now if you update the data in runtime (and it must be 99% of all cases, who shows static data anyway?) the charts show literally nothing so I have to inject chart component in every page and call this refresh stuff every time the data changes. I think it is a huge step backward in usability

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants