Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase: ES LINTER ISSUE #13641

Closed
leoncydsilva opened this issue Sep 9, 2023 · 0 comments · Fixed by #13642
Closed

Codebase: ES LINTER ISSUE #13641

leoncydsilva opened this issue Sep 9, 2023 · 0 comments · Fixed by #13642
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@leoncydsilva
Copy link
Contributor

leoncydsilva commented Sep 9, 2023

Describe the bug

ESLINT is not working correctly in the repository. There are two main errors

`Error: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.json#overrides[0]': Cannot find module '@typescript-eslint/eslint-plugin'
Require stack:

  • /Users/leoncydsilva/Documents/GitHub/primeng/placeholder.js
    Referenced from: /Users/leoncydsilva/Documents/GitHub/primeng/.eslintrc.json
    at Module._resolveFilename (node:internal/modules/cjs/loader:1129:15)
    at Function.resolve (node:internal/modules/cjs/helpers:116:19)
    at Object.resolve (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2337:46)
    at ConfigArrayFactory._loadPlugin (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3404:33)
    at ConfigArrayFactory._loadExtendedPluginConfig (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3224:29)
    at ConfigArrayFactory._loadExtends (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3145:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3086:25)
    at _normalizeObjectConfigDataBody.next ()
    at ConfigArrayFactory._normalizeObjectConfigData (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3031:20)
    at _normalizeObjectConfigData.next ()
    Uncaught exception received.
    Error: Failed to load plugin '@typescript-eslint' declared in '.eslintrc.json#overrides[0]': Cannot find module '@typescript-eslint/eslint-plugin'
    Require stack:
  • /Users/leoncydsilva/Documents/GitHub/primeng/placeholder.js
    Referenced from: /Users/leoncydsilva/Documents/GitHub/primeng/.eslintrc.json
    at Module._resolveFilename (node:internal/modules/cjs/loader:1129:15)
    at Function.resolve (node:internal/modules/cjs/helpers:116:19)
    at Object.resolve (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:2337:46)
    at ConfigArrayFactory._loadPlugin (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3404:33)
    at ConfigArrayFactory._loadExtendedPluginConfig (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3224:29)
    at ConfigArrayFactory._loadExtends (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3145:29)
    at ConfigArrayFactory._normalizeObjectConfigDataBody (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3086:25)
    at _normalizeObjectConfigDataBody.next ()
    at ConfigArrayFactory._normalizeObjectConfigData (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@eslint/eslintrc/dist/eslintrc.cjs:3031:20)
    at _normalizeObjectConfigData.next ()
    [Info - 15:51:22] ESLint library loaded from: /Users/leoncydsilva/Documents/GitHub/primeng/node_modules/eslint/lib/api.js`

which is because package @typescript-eslint/eslint-plugin": "^6.6.0 is missing in repo

and

Error: Error while loading rule '@angular-eslint/template/eqeqeq': You have used a rule which requires '@angular-eslint/template-parser' to be used as the 'parser' in your ESLint config. Occurred while linting /Users/leoncydsilva/Documents/GitHub/primeng/src/app/components/animate/animate.ts at ensureTemplateParser (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@angular-eslint/utils/dist/eslint-plugin-template/parser-services.js:21:15) at create (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@angular-eslint/eslint-plugin-template/dist/rules/eqeqeq.js:39:42) at Object.create (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/@angular-eslint/eslint-plugin-template/dist/utils/create-eslint-rule.js:20:24) at createRuleListeners (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/eslint/lib/linter/linter.js:870:21) at /Users/leoncydsilva/Documents/GitHub/primeng/node_modules/eslint/lib/linter/linter.js:1040:110 at Array.forEach (<anonymous>) at runRules (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/eslint/lib/linter/linter.js:977:34) at Linter._verifyWithoutProcessors (/Users/leoncydsilva/Documents/GitHub/primeng/node_modules/eslint/lib/linter/linter.js:1330:31) at /Users/leoncydsilva/Documents/GitHub/primeng/node_modules/eslint/lib/linter/linter.js:1812:29 at Array.map (<anonymous>)

**which is becuase we are trying to use rule **@angular-eslint/template/eqeqeq** without the required parser** **@angular-eslint/template-parser**

Environment

.

Reproducer

No response

Angular version

16.1.2

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.0.1

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@leoncydsilva leoncydsilva added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 9, 2023
@leoncydsilva leoncydsilva changed the title Component: Title Component: ES LINTER ISSUE Sep 9, 2023
@leoncydsilva leoncydsilva changed the title Component: ES LINTER ISSUE Codebase: ES LINTER ISSUE Sep 9, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants