Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiselect: Incorrect view with selected items #13654

Closed
BearsPunch opened this issue Sep 12, 2023 · 4 comments
Closed

Multiselect: Incorrect view with selected items #13654

BearsPunch opened this issue Sep 12, 2023 · 4 comments
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@BearsPunch
Copy link

BearsPunch commented Sep 12, 2023

Describe the bug

After update in common.css.p-icon-wrapper from display: flex to display: inline-flex; with selected items, control renders incorrect, with additional row.
image

Environment

any

Reproducer

No response

Angular version

16.2.2

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.14.0

Browser(s)

any

Steps to reproduce the behavior

  1. Create Multiselect
  2. Select values

Expected behavior

Correct render
image

@BearsPunch BearsPunch added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 12, 2023
@SoyDiego
Copy link
Contributor

Hi, can you share a stackblitz, please?

@MayerMar
Copy link

Demo: one p-multiselect with the problem, one p-multiselect with the fix (forced via styles.css)
https://stackblitz.com/edit/7qd5w1?file=src%2Fstyles.scss

Only happens when the Input [showClear] is used.
Class that causes the Problem:

.p-icon-wrapper {
    display: inline-flex;
}

@SoyDiego
Copy link
Contributor

Demo: one p-multiselect with the problem, one p-multiselect with the fix (forced via styles.css) https://stackblitz.com/edit/7qd5w1?file=src%2Fstyles.scss

Only happens when the Input [showClear] is used. Class that causes the Problem:

.p-icon-wrapper {
    display: inline-flex;
}

Thanks for the demo. I will create the PR fixing this issue soon! :)

@SoyDiego
Copy link
Contributor

Hi, I created a PR in the project primeng-sass-theme because is the correct place in this case.
You can check here: primefaces/primeng-sass-theme#54.

fixed multiselect

I cannot modify the line that you suggested @MayerMar because will affect another styles.
Now it's solved and we should wait PrimeNG Team approve it.

Thanks

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 29, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.2 milestone Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

4 participants