Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog - remove entryComponents from docs #13679

Closed
tomer953 opened this issue Sep 16, 2023 · 3 comments · Fixed by #13682
Closed

DynamicDialog - remove entryComponents from docs #13679

tomer953 opened this issue Sep 16, 2023 · 3 comments · Fixed by #13682
Labels
Component: Documentation Issue or pull request is related to Documentation
Milestone
16.4.0

Comments

@tomer953
Copy link
Contributor

Describe the bug

According to the current documentation for Dynamic Dialogs, it is stated that entryComponents are required for dynamic dialogs.

Since the dynamically loaded content is not defined at build time, a configuration is necessary using the entryComponents of your parent module

However, with Angular 9 and above, using the Ivy rendering engine, entryComponents are generally no longer necessary. This could lead to confusion for developers using newer versions of Angular

Environment

.

Reproducer

No response

Angular version

16.2.0

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

it should mention that entryComponents are generally not required when using Angular 9 and above with the Ivy rendering engine. This would help developers avoid unnecessary configuration and reduce confusion.
@tomer953 tomer953 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 16, 2023
@tomer953 tomer953 changed the title Component: DynamicDialog - remove entryComponents from docs DynamicDialog - remove entryComponents from docs Sep 16, 2023
@SoyDiego
Copy link
Contributor

Thanks for report.
PRs are welcome! :)

@tomer953
Copy link
Contributor Author

NP.
#13682

@tomer953 tomer953 mentioned this issue Sep 16, 2023
Merged
@SoyDiego
Copy link
Contributor

NP. #13682

Thanks

@gucal gucal added this to the 16.3.2 milestone Sep 17, 2023
@gucal gucal added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
16.4.0
Development

Successfully merging a pull request may close this issue.

docs: remove entryComponents from DynamicDialogs tomer953/primeng
3 participants
@tomer953 @SoyDiego @gucal