Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dismissableMask is not working on ConfirmationPopup #13714

Closed
MussaratAziz opened this issue Sep 22, 2023 · 2 comments · Fixed by #13721
Closed

dismissableMask is not working on ConfirmationPopup #13714

MussaratAziz opened this issue Sep 22, 2023 · 2 comments · Fixed by #13721
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
16.4.0

Comments

@MussaratAziz
Copy link

Describe the bug

dismissableMask is not working on ConfirmationPopup i want to set to false.

Environment

.

Reproducer

No response

Angular version

16

PrimeNG version

16.3.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.12.1

Browser(s)

No response

Steps to reproduce the behavior

.

Expected behavior

dismissableMask should work by setting it to true or false
@MussaratAziz MussaratAziz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Sep 22, 2023
@SoyDiego SoyDiego mentioned this issue Sep 24, 2023
Merged
@SoyDiego
Copy link
Contributor

Hi @MussaratAziz , I have checked the problem and you are right.
I did a PR solving the problem. You can check it here: #13721
Now we should wait PrimeNG Team approve it if they think the solution is OK for them.

Regards

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 25, 2023
@cetincakiroglu cetincakiroglu added this to the 16.4.0 milestone Sep 25, 2023
@MussaratAziz
Copy link
Author

@SoyDiego cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
16.4.0
Development

Successfully merging a pull request may close this issue.

13714 - fix dismissableMask on confirmPopup component SoyDiego/primeng
3 participants
@MussaratAziz @SoyDiego @cetincakiroglu