Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MultiSelect: Label does not properly update when properties change #13862

Closed
doener006 opened this issue Oct 12, 2023 · 0 comments
Closed

MultiSelect: Label does not properly update when properties change #13862

doener006 opened this issue Oct 12, 2023 · 0 comments
Labels
LTS-FIXED-14.2.16 LTS-FIXED-15.4.13 Fixed in PrimeNG LTS 15.4.13 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@doener006
Copy link

Describe the bug

The shown label is calculated using updateLabel(). This function depends on the fields selectedItemsLabel, maxSelectedLabels and displaySelectedLabel, where changing them does not trigger updateLabel(). Other fields the label depends on are already properties and trigger the update function in the setter.

Environment

N/A

Reproducer

No response

Angular version

^16.2.0

PrimeNG version

16.4.1

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v18.16.1

Browser(s)

No response

Steps to reproduce the behavior

  1. Create a p-multiselect with selectedItemsLabel, maxSelectedLabels and/or displaySelectedLabel
  2. Select some items (The label changes in this case)
  3. Update the selectedItemsLabel

Expected behavior

Label displayed in .p-multiselect-label should be updated on selectedItemsLabel, maxSelectedLabels or displaySelectedLabel change.

@doener006 doener006 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 12, 2023
@cetincakiroglu cetincakiroglu added this to the 16.8.0 milestone Nov 17, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-14.2.16 LTS-FIXED-15.4.13 Fixed in PrimeNG LTS 15.4.13 LTS-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants