Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ListBox | VirtualScroller support #13939

Closed
cetincakiroglu opened this issue Oct 23, 2023 · 3 comments
Closed

ListBox | VirtualScroller support #13939

cetincakiroglu opened this issue Oct 23, 2023 · 3 comments
Assignees
@cetincakiroglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Milestone
16.7.0

Comments

@cetincakiroglu
Copy link
Contributor

Implement virtual scroll to listbox
@cetincakiroglu cetincakiroglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 23, 2023
@cetincakiroglu cetincakiroglu self-assigned this Oct 23, 2023
@cetincakiroglu cetincakiroglu added this to the 16.5.2 milestone Oct 23, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 23, 2023
@maruthumj
Copy link
Contributor

Hi @cetincakiroglu. I'm new to open source and I have some doubts regarding this. do we need to create separate props for itemSize, scrollHeight and other props which are already exisiting in p-virtualScroller for listbox as well or we can implement by adding the custom itemSize and scrollHeight? thanks!

@cetincakiroglu cetincakiroglu modified the milestones: 16.6.0, 16.7.0 Oct 26, 2023
@cetincakiroglu
Copy link
Contributor Author

Hi @maruthumj

p-virtualScroller and the p-scroller is two different components. You don't need to change anything about p-virtualScroll since this issue is about the p-scroller implementation of ListBox component

@cetincakiroglu
Copy link
Contributor Author

Fixed in 51bc2b5

@cetincakiroglu cetincakiroglu added Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
16.7.0
Development

No branches or pull requests
2 participants
@maruthumj @cetincakiroglu