Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Angular 17? #14063

Closed
Sebastian-G opened this issue Nov 8, 2023 · 22 comments
Closed

Upgrade to Angular 17? #14063

Sebastian-G opened this issue Nov 8, 2023 · 22 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@Sebastian-G
Copy link

Is there any release plan for Angular 17?
And the introduction of DesignTokens matching the Firma Files?

@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 8, 2023
@b1rigu
Copy link

b1rigu commented Nov 9, 2023

Yes please add angular 17 support

@mircowidmer
Copy link

I'm getting the following error after upgrading to Angular 17:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR! 
npm ERR! While resolving: out-of-office@0.0.0
npm ERR! Found: @angular/common@17.0.1
npm ERR! node_modules/@angular/common
npm ERR!   @angular/common@"^17.0.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer @angular/common@"^16.2.0" from primeng@16.7.2
npm ERR! node_modules/primeng
npm ERR!   primeng@"^16.7.2" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.

I assume the reason is, PrimeNG 16.7.2 is not ready for Angular 17.

@Rotzbua
Copy link
Contributor

Rotzbua commented Nov 9, 2023

I assume the reason is, PrimeNG 16.7.2 is not ready for Angular 17.

PrimeNG version supports only the according Angular version.
In the past it took about a month until a PrimeNG release was available.

@ces6jedi
Copy link

Too many crashes and bugs for me to continue with this framework, so slow to move to Angualr 17 as well ☹️

@gjlmotea
Copy link

I can't wait to get started with v17 too.

@DominikPieper
Copy link

I’m waiting too. But let’s keep realistic, Angular 17 is just a few days out. Anyone know if the work already begun?

@alexnoise79
Copy link
Contributor

v17 is full of new syntax especially from point of view of templates, i think will take some time to refactor the codebase of primeng...

so seat back, relax and enjoy your flight!

@alydemah
Copy link

v17 is full of new syntax especially from point of view of templates, i think will take some time to refactor the codebase of primeng...

so seat back, relax and enjoy your flight!

Is a refactor necessary, the old control flow is still supported and should work with no issues with v17.
Or it's planned to move to new control flow in the new release of primeng?

@leogouveia
Copy link

v17 is full of new syntax especially from point of view of templates, i think will take some time to refactor the codebase of primeng...
so seat back, relax and enjoy your flight!

Is a refactor necessary, the old control flow is still supported and should work with no issues with v17. Or it's planned to move to new control flow in the new release of primeng?

In addition, many of the new features are in developer preview. I think it's best to release them from the preview in order to refactor the code.

@MAN-Sendance
Copy link

This issue should be prioritized. I also think that it is not necessary to do a whole refactoring immediately since the old syntax is still supported by Angular 17.

@morsagmon
Copy link

What I wish is to get a clear statement from PrimeFaces rep on their plan, so that we can plan accordingly.

@puschie286
Copy link

note: https://github.com/orgs/primefaces/discussions/424

@alexnoise79
Copy link
Contributor

v17 is full of new syntax especially from point of view of templates, i think will take some time to refactor the codebase of primeng...
so seat back, relax and enjoy your flight!

Is a refactor necessary, the old control flow is still supported and should work with no issues with v17. Or it's planned to move to new control flow in the new release of primeng?

well of course the old control flow is still supported, but without a refactor we will not be able to enjoy the real power of v17, honestly i don't know what is the current plan, probably refactor will be done step by step.

i hope there will be a migration tool to help developers in this high risk task

@DominikPieper
Copy link

@alexnoise79 there’s a schematic for the migration.

ng generate @angular/core:control-flow

@SERGE3-g
Copy link

Salve a tutti mi potreste aiutare a risolvere questo problem perchè ho installato angular v17 e mi da questo problema per favore aiutatemi.
https://github.com/orgs/primefaces/discussions/424#discussioncomment-7581849

Screenshot 2023-11-15 alle 23 00 10

@cetincakiroglu cetincakiroglu self-assigned this Nov 16, 2023
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 16, 2023
@cetincakiroglu cetincakiroglu added this to the 17.0.0-rc.1 milestone Nov 16, 2023
@cetincakiroglu
Copy link
Contributor

Hi everyone!

As the Core team, following the recent accessibility update we released, we are currently working on fixing the reported issues and focusing on implementing the data section accessibility. After rolling out the accessibility implementation with one last release in v16, we will release PrimeNG 17. If everything goes smoothly, we plan to release the PrimeNG 17.0.0-rc.1 version with Angular 17 support next week.

@jhcpeixoto
Copy link
Contributor

jhcpeixoto commented Nov 19, 2023

@cetincakiroglu When will all the components be refactored to adapt to version v17 with (Conditional statements)? (If that's going to happen)

@armingdev
Copy link

At this point I think it best to release some initial support in RC1, so ppl can actually upgrade their apps to the latest version of Angular, then to get the full power of the v17, everything should be refactored with all benefits of the v17 (new control flow, signals, builders ...).

@slyk
Copy link

slyk commented Nov 23, 2023

@cetincakiroglu thank you!! for your service and being contributor of such great lib.

Don't sure that "data section accessibility" is more important now than giving incomers to use PrimeNG. Now in renaissance of Angular we have a lot of them wanted to try new features. And now they decide what to use. The decisions that they will do right now will lead to community size around that PrimeNG and its value/place in other libs.

Maybe working with angular pre-preleases to have some beta at the Angular release date will be the best idea to not lose newcomers. They have simple projects and ready to start working with a beta. But they mostly don't ready to start with older Angular lib when the new version is released. (don't know if angular have some pre-release / RC open to public, hope so).

I guess me and other people who into it more that couple of years can wait (and should wait) some time for all migration schematics and bugs to be fixed before moving their bigger projects to new versions. So its ok. That is why above I've talked about newcomers mostly. But the community needs them :)

this could be just a fast port to v17, without any new features using. just so people could start using it in their first small projects, those buttons and select lists :)

P.S. don't really know the details behind the "data section accessibility", sorry.

@cetincakiroglu
Copy link
Contributor

Hi folks,

We are currently testing PrimeNG 17 to determine if there are any breaking changes. Our plan is to present 17.0.0-rc.1 to you tomorrow. We apologize for the delay, but we couldn't carry over all the reported bugs from version 16 related to accessibility updates. We are working to provide you with a stable experience. Thank you for your patience and understanding. As a team, we are eagerly looking forward to delivering PrimeNG 17 to you!

@cetincakiroglu
Copy link
Contributor

Fixed in 465482e

@MAN-Sendance
Copy link

Thanks a million! @cetincakiroglu

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests