Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting p-table with non exportable columns may lead in unecessary ending csvSeparator #14248

Closed
Cr3aHal0 opened this issue Nov 29, 2023 · 0 comments · Fixed by #14416
Closed
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Cr3aHal0
Copy link
Contributor

Describe the bug

Considering a table with 3 columns and only the first two being exportable, the current behavior will result in a exceeding csvSeparator after the second column within the CSV file, thus displaying an empty 3rd column within most csv file readers.

Environment

Angular 16 & PrimeNG 16

Reproducer

No response

Angular version

16.2.12

PrimeNG version

16.9.1

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

20.9.0

Browser(s)

No response

Steps to reproduce the behavior

  1. have a table with more than 1 column
  2. have every single column be exportable, except the last one
  3. perform export through table exportCsv function
  4. Open generated file
  5. Every line is ending with csvSeparator before new line

Expected behavior

  1. have a table with more than 1 column
  2. have every single column be exportable, except the last one
  3. perform export through table exportCsv function
  4. Open generated file
  5. Every line should be ending with last character of the value of the last column followed by the newline character
@Cr3aHal0 Cr3aHal0 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 29, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 4, 2024
@cetincakiroglu cetincakiroglu added this to the 17.3.1 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
2 participants