Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AutoComplete: (Multiple) Placeholder does not disappear after selecting item #14376

Closed
c-o-l-i-n opened this issue Dec 15, 2023 · 1 comment
Closed

AutoComplete: (Multiple) Placeholder does not disappear after selecting item #14376

c-o-l-i-n opened this issue Dec 15, 2023 · 1 comment
Assignees
@cetincakiroglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.3.0

Comments

@c-o-l-i-n
Copy link
Contributor

Describe the bug

In PrimeNG 16.6.0 and earlier, selecting an item in a multi-select AutoComplete removes the placeholder.

In PrimeNG v16.7.0 and later, selecting an item in a multi-select AutoComplete does NOT remove the placeholder.

PrimeNG 16.6.0 (Stackblitz)
16.6.0 before
16.6.0 after

PrimeNG 16.7.0 (Stackblitz) and PrimeNG 17.1.0 (Stackblitz)
16.7.0 before
16.7.0 after

I believe this regression is caused by the removal of this line in v16.7.0:
[attr.placeholder]="value && value.length ? null : placeholder"

Environment

Stackblitz

Reproducer

https://stackblitz.com/edit/stackblitz-starters-srrovt?file=package.json,src%2Fmain.ts

Angular version

16.2.12

PrimeNG version

16.7.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

Whichever version Stackblitz uses

Browser(s)

No response

Steps to reproduce the behavior

  1. Create an AutoComplete with [multiple]="true"
  2. Select an item

Expected behavior

The placeholder should disappear after selecting an item. Behavior should remain consistent with previous versions.
@c-o-l-i-n c-o-l-i-n added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 15, 2023
@mehmetcetin01140 mehmetcetin01140 added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 19, 2023
@mehmetcetin01140
Copy link
Contributor

Hi,

Thanks for reporting the issue!

@cetincakiroglu cetincakiroglu added this to the 17.3.0 milestone Dec 26, 2023
@cetincakiroglu cetincakiroglu removed the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 27, 2023
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 28, 2023
@cetincakiroglu cetincakiroglu self-assigned this Dec 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cetincakiroglu cetincakiroglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.3.0
Development

No branches or pull requests
3 participants
@c-o-l-i-n @cetincakiroglu @mehmetcetin01140