Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Galleria: After images change not correct numVisible value in component #14401

Closed
Darkcooder opened this issue Dec 19, 2023 · 1 comment · Fixed by #14402
Closed

Galleria: After images change not correct numVisible value in component #14401

Darkcooder opened this issue Dec 19, 2023 · 1 comment · Fixed by #14402
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.2.0

Comments

@Darkcooder
Copy link

Describe the bug

If change images after images length less numVisible, numVisible remains old images length.

Environment

Production

Reproducer

No response

Angular version

14.0.0

PrimeNG version

14.0.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

16.13.1

Browser(s)

Chrome 90

Steps to reproduce the behavior

  1. set property [numVisible] of p-galleria to 3
  2. set property [value] of p-galleria to array of 1 item
  3. set property [value] of p-galleria to array of 3 items
  4. We have 1 visible item in Galleria, but must be 3

Expected behavior

No response
@Darkcooder Darkcooder added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Dec 19, 2023
@Darkcooder Darkcooder mentioned this issue Dec 19, 2023
Merged
@Darkcooder Darkcooder changed the title Galleria: After images change no correct numVisible param in component Galleria: After images change not correct numVisible value in component Dec 19, 2023
@cetincakiroglu cetincakiroglu added Resolution: Cannot Replicate Issue could not be replicated by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 20, 2023
@github-actions GitHub Actions
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels Dec 20, 2023
@cetincakiroglu cetincakiroglu added this to the 17.2.0 milestone Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.2.0
Development

Successfully merging a pull request may close this issue.

Galleria bug fix: If change images after images length less numVisibl… Darkcooder/primeng
2 participants
@Darkcooder @cetincakiroglu