Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton contains a typo on "aria-haspopup" attribute #14533

Closed
Cue-Ai-NGinEar opened this issue Jan 11, 2024 · 0 comments · Fixed by #14538
Closed

SplitButton contains a typo on "aria-haspopup" attribute #14533

Cue-Ai-NGinEar opened this issue Jan 11, 2024 · 0 comments · Fixed by #14538
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.3.3

Comments

@Cue-Ai-NGinEar
Copy link

Describe the bug

In file src/app/components/splitbutton/splitbutton.ts the "aria-haspopup" attribute has a typo - implemented as "aria-aria-haspopup". Pretty basic and straightforward to fix.

Environment

Bug in source code. Can also be seen at primeng.org/splitbutton by inspecting the component.

Reproducer

No response

Angular version

N/A

PrimeNG version

17.0.5

Build / Runtime

TypeScript

Language

TypeScript

Node version (for AoT issues node --version)

N/A

Browser(s)

No response

Steps to reproduce the behavior

Simply inspect the split button component. Axe and WAVE scans highlight the invalid aria attribute on this component.

Expected behavior

Aria attribute does not have a typo that means it is flagged by accessibility tests.
@Cue-Ai-NGinEar Cue-Ai-NGinEar added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 11, 2024
@mehmetcetin01140 mehmetcetin01140 added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 11, 2024
@navedqb navedqb mentioned this issue Jan 12, 2024
Merged
@cetincakiroglu cetincakiroglu added this to the 17.3.3 milestone Jan 12, 2024
@mertsincan mertsincan added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.3.3
Development

Successfully merging a pull request may close this issue.

fix: fix typo in splitbutton qburst/primeng-1
4 participants
@mertsincan @cetincakiroglu @mehmetcetin01140 @Cue-Ai-NGinEar