Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown: can't select input with Shift + Home / Shift + End #14540

Closed
perceptron8 opened this issue Jan 12, 2024 · 7 comments
Closed

Dropdown: can't select input with Shift + Home / Shift + End #14540

perceptron8 opened this issue Jan 12, 2024 · 7 comments
Assignees
Labels
LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@perceptron8
Copy link

Describe the bug

Shift + Home / Shift + End doesn't select text.

Environment

https://stackblitz.com/

Reproducer

https://github-qox9rx.stackblitz.io

Angular version

17.0.9

PrimeNG version

17.3.2

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

21.5.0

Browser(s)

Google Chrome: 120.0.6099.199, Firefox: 121.0

Steps to reproduce the behavior

  1. Type anything
  2. Press Shift + Home
  3. Press Home
  4. Press Shift + End
  5. Press End

Expected behavior

Text should become selected in steps 2 and 4.

@perceptron8 perceptron8 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 12, 2024
@perceptron8 perceptron8 changed the title Component: Dropdown Dropdown: can't select input with Shift + Home / Shift + End Jan 12, 2024
@perceptron8
Copy link
Author

Stackblitz url doesn't seem to work, so here's MCVE:

<p-dropdown [filter]="true" [options]="['Australia', 'Brazil', 'China']">

@mertsincan
Copy link
Member

Thank you! we'll check it before the milestone is released.

@mertsincan mertsincan added Status: Pending Review Issue or pull request is being reviewed by Core Team and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 15, 2024
@mertsincan mertsincan added this to the 17.4.0 milestone Jan 15, 2024
@cetincakiroglu cetincakiroglu self-assigned this Jan 23, 2024
@cetincakiroglu
Copy link
Contributor

Hi,

Selection by specifically shift + end and shift + home keys are not supported. shift + end and shift + home are navigate to either first or last element in the dropdown. Set selectOnFocus to true to enable selection by focusing on an option.

Here is a stackblitz example: https://stackblitz.com/edit/dbpmhs?file=src%2Fapp%2Fdemo%2Fdropdown-basic-demo.html

@cetincakiroglu cetincakiroglu removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jan 23, 2024
@cetincakiroglu cetincakiroglu removed this from the 17.4.0 milestone Jan 23, 2024
@perceptron8
Copy link
Author

perceptron8 commented Jan 23, 2024

@cetincakiroglu In stackblitz example you gave:

  1. there is no [filter]="true", thus no text input
  2. shift is unnecessary to navigate, first/last item can be selected with home/end only (is this another bug?)

Selection by specifically shift + end and shift + home keys are not supported.

What kind of selection did you have in mind?

@cetincakiroglu
Copy link
Contributor

My bad, I missed the explanation, I got you know, I'll check it again. Thanks for letting me know 👍🏻

@perceptron8
Copy link
Author

Please also note, that this is a regression. Text selection (and I mean text input which is used for filtering) was working properly on v15, but stopped working on v16.

@cetincakiroglu cetincakiroglu added this to the 17.4.0 milestone Jan 24, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 24, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-16-PORTABLE and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 24, 2024
@perceptron8
Copy link
Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants