Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

p-MultiSelect: Clear Button does not work #14585

Closed
jpgoelz opened this issue Jan 18, 2024 · 15 comments
Closed

p-MultiSelect: Clear Button does not work #14585

jpgoelz opened this issue Jan 18, 2024 · 15 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jpgoelz
Copy link

jpgoelz commented Jan 18, 2024

Describe the bug

When using [showClear]="true" clicking on the X to clear the selection of the MultiSelect no longer clears the selection. Instead, the dropdown is opened and closed.

primeng

This issue is new with 17.3.3 and does not exist in 17.3.2.

While this is off-topic, and we are generally very happy with the product you provide, please try and improve your quality assurance mechanisms. The last few updates have introduced a lot of breaking bugs in the dropdown menus that have rendered parts of our application unusable and resulted in having to invest a lot of expensive time into trying to find these issues. And I am not talking about major or minor updates, but patch updates. It is a bad sign, if the team starts to talk about not updating PrimeNG unless absolutely necessary.

Environment

n/a

Reproducer

No response

Angular version

17.1.0

PrimeNG version

17.3.3

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

20

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Set [showClear]="true" on your <p-MultiSelect>
  2. Select Items from the Dropdown
  3. Click on the X and see that the selection remains while the dropdown is opened and closed

Expected behavior

The selection is cleared instead.

@jpgoelz jpgoelz added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jan 18, 2024
@cetincakiroglu cetincakiroglu added this to the 17.4.0 milestone Jan 18, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Jan 18, 2024
@adri95cadiz
Copy link

I've also tested this in p-dropdown and p-calendar components, and both have the same problem; in version 17.3.3 as well as in version 17.3.2, for now I have downgraded to version 17.3.1 which doesn't have this issue.

@jacqueslareau
Copy link

Experiencing the issue with p-dropdown

@denny99
Copy link
Contributor

denny99 commented Jan 23, 2024

Might be related to #14606. ?

@cetincakiroglu
Copy link
Contributor

Hi @jpgoelz,

Could you please provide a stackblitz example, seems it works here https://stackblitz.com/edit/itiykk?file=src%2Fapp%2Fdemo%2Fmulti-select-basic-demo.html

@cetincakiroglu
Copy link
Contributor

I've also tested this in p-dropdown and p-calendar components, and both have the same problem; in version 17.3.3 as well as in version 17.3.2, for now I have downgraded to version 17.3.1 which doesn't have this issue.

Could you please create separate issues for other components by providing stackblitz examples so we can understand the issue and target them one by one?

@cetincakiroglu cetincakiroglu added Resolution: Cannot Replicate Issue could not be replicated by Core Team and removed Type: Bug Issue contains a bug related to a specific component. Something about the component is not working labels Jan 24, 2024
Copy link

We're unable to replicate your issue, if you are able to create a reproducer by using PrimeNG Issue Template or add details please edit this issue. This issue will be closed if no activities in 20 days.

@cetincakiroglu cetincakiroglu self-assigned this Jan 24, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.4.0, 17.5.0 Jan 24, 2024
@jacqueslareau
Copy link

If you go on the primeng site directly (primeng.org) and click on Get Started, then select the Dropdown component, the first example on the site does not work.

But if you go directly to primeng.org/dropdown , it works.

I'm not sure how to replicate this.

@astranCZ
Copy link

This is replicate issue.
The p-dropdown component does not work properly when the p-calendar is on the page.

https://stackblitz.com/edit/github-pmdtzh?file=src%2Fapp%2Fapp.component.html%3AL19,src%2Fapp%2Fapp.component.ts

@denny99
Copy link
Contributor

denny99 commented Jan 25, 2024

So then its fixed with #14607

@jpgoelz
Copy link
Author

jpgoelz commented Jan 25, 2024

This is replicate issue. The p-dropdown component does not work properly when the p-calendar is on the page.

https://stackblitz.com/edit/github-pmdtzh?file=src%2Fapp%2Fapp.component.html%3AL19,src%2Fapp%2Fapp.component.ts

Thank you for this. I was at a loss, as I could not replicate the issue myself, except for in our application. We do use calendar and dropdown as well.

@cetincakiroglu, I added a calendar to your working StackBlitz and the issue becomes visible for p-multiSelect as well:
https://stackblitz.com/edit/itiykk-x1yhiy?file=src%2Fapp%2Fdemo%2Fmulti-select-basic-demo.html

@jacqueslareau
Copy link

Thank you. Is there a workaround we can use until it is fixed?

@denny99
Copy link
Contributor

denny99 commented Jan 25, 2024

Overwrite the css in your angular global styles file.

.p-icon-wrapper {
pointer-events: unset (!important depending on your setup)
}

@psarno
Copy link

psarno commented Jan 25, 2024

This also impacts <p-password [toggleMask]="true"> if a <p-calendar> is on the page.

You can not click the "eye" icon to mask/show the password.

The CSS global style workaround above does resolve it.

@STotev
Copy link

STotev commented Jan 26, 2024

I can confirm the same behaviour for the dropdown. Though, it's hard to replicate it on stackblitz. Somehow it works there.

@denny99 workaround works for me, too.

@cetincakiroglu
Copy link
Contributor

Hi,

This issue is related with #14606 and it was also replicated in dropdown component. The issue caused by possible CSS leak in the calendar component. We've fixed the issue by updating p-icon-wrapper style rule. Probably, it'll fix this issue too. I'm assuming that it's fixed and closing the issue. Please try with the upcoming release and let us know if the issue persists.

@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Resolution: Cannot Replicate Issue could not be replicated by Core Team labels Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

8 participants