Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve property check in datatable #1499

Merged
merged 2 commits into from Dec 6, 2016
Merged

Improve property check in datatable #1499

merged 2 commits into from Dec 6, 2016

Conversation

upmauro
Copy link
Contributor

@upmauro upmauro commented Dec 5, 2016

Have one problem in fix #1182

   null === undefined // false
   null == undefined // true
   null === null // true

We need use just "==" to check if have value in the field, it's wrong use "===".

If we try check a JSON with null values, the exception keep occurring.

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 6, 2016
@cagataycivici cagataycivici added this to the 1.0.2 milestone Dec 6, 2016
@cagataycivici cagataycivici self-assigned this Dec 6, 2016
@cagataycivici cagataycivici merged commit 05a9913 into primefaces:master Dec 6, 2016
@cagataycivici cagataycivici changed the title Revert #1182 patch 1 Improve property check in datatable Dec 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants