Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: ConfirmDialog Accessibility #15108

Closed
WTW-Jacob-Evans opened this issue Mar 20, 2024 · 2 comments
Closed

Component: ConfirmDialog Accessibility #15108

WTW-Jacob-Evans opened this issue Mar 20, 2024 · 2 comments
Assignees
@mehmetcetin01140
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE LTS-FIXED-16.9.8 PRO Support Issue was reported by PRO User
Milestone
17.13.0

Comments

@WTW-Jacob-Evans
Copy link

Describe the bug

Using the Axe DevTools, scanning a confirmation dialog will raise an accessibility issue related to a missing aria label on the inner dialog of the pop-up.

image
image

Environment

Windows 10

Reproducer

No response

Angular version

17.2.3

PrimeNG version

17.11.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.18.0

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@WTW-Jacob-Evans WTW-Jacob-Evans added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 20, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 20, 2024
@TaneliTuomola TaneliTuomola mentioned this issue Mar 20, 2024
Merged
@TaneliTuomola
Copy link

I think this issue is already fixed in #15075 that involved the following components: Dialog, ConfirmDialog and DynamicDialog

@cetincakiroglu cetincakiroglu added Component: Accessibility Issue or pull request is related to WCAG or ARIA PRO Support Issue was reported by PRO User and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 25, 2024
@cetincakiroglu
Copy link
Contributor

Fixed in #15075

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mehmetcetin01140 mehmetcetin01140

Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE LTS-FIXED-16.9.8 PRO Support Issue was reported by PRO User
Projects
None yet
Milestone
17.13.0
Development

No branches or pull requests
4 participants
@cetincakiroglu @TaneliTuomola @mehmetcetin01140 @WTW-Jacob-Evans