Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicDialog | Add child component reference on component load #15145

Closed
cetincakiroglu opened this issue Mar 22, 2024 · 0 comments · Fixed by #14957
Closed

DynamicDialog | Add child component reference on component load #15145

cetincakiroglu opened this issue Mar 22, 2024 · 0 comments · Fixed by #14957
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Milestone
17.13.0

Comments

@cetincakiroglu
Copy link
Contributor

cetincakiroglu commented Mar 22, 2024 •
edited

With the current implementation is hard to do things like use the child component public API (i.e. to populate inputs) because the component is created asynchronously and trying to pass data using the angular lifecycle hooks to access the child component throws errors because often is undefined. Pass the data through the DynamicDialogConfig is a bit tricky.
@cetincakiroglu cetincakiroglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request labels Mar 22, 2024
@cetincakiroglu cetincakiroglu added this to the 17.13.0 milestone Mar 22, 2024
@cetincakiroglu cetincakiroglu linked a pull request Mar 22, 2024 that will close this issue
feat: Dynamic dialog. Child component reference to be able to #14957
Merged
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
@cetincakiroglu cetincakiroglu removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Milestone
17.13.0
Development

Successfully merging a pull request may close this issue.

feat: Dynamic dialog. Child component reference to be able to vigalo/primeng
1 participant
@cetincakiroglu