Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Messages #15260

Closed
jacver opened this issue Apr 11, 2024 · 0 comments
Closed

Component: Messages #15260

jacver opened this issue Apr 11, 2024 · 0 comments
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@jacver
Copy link
Contributor

jacver commented Apr 11, 2024

Describe the bug

Messages added to the Message Service do not use the closable property defined in the message object. They only use the closable property applied to the <p-messages> element.

This means that if you are adding multiple messages via the Message Service, you cannot have some be closable and some not.

Environment

All environments

Reproducer

https://stackblitz.com/run?file=src%2Fapp%2Fdemo%2Fmessages-service-demo.ts

Angular version

17.3.1

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.17.1

Browser(s)

Chrome

Steps to reproduce the behavior

  1. Add multiple messages to the message service
  2. On the HTML <p-messages element do not set a value for closable (default is true)
  3. On one message set closable: true
  4. On another message set closable: false
  5. Both messages will be closable (default behavior)

Expected behavior

Message 1 should be closable
Message 2 should not be closable

@jacver jacver added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 11, 2024
@cetincakiroglu cetincakiroglu added this to the 17.14.0 milestone Apr 18, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants