Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Component: Editor isn't functional within dialogs #15324

Open
aaron-cardenas opened this issue Apr 20, 2024 · 2 comments
Open

Component: Editor isn't functional within dialogs #15324

aaron-cardenas opened this issue Apr 20, 2024 · 2 comments
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible

Comments

@aaron-cardenas
Copy link

Describe the bug

Since the EditorModule fix doesn't support SSR in v17.13.0, the editor isn't functional within dialogs. The same issue persists in 17.14.x. Reverting to the 17.12.x fix leaves you with a choice between this functionality and SSR compatibility.
#8817

Environment

Angular version 17.3.5
PrimeNG version 17.13.0 - 17.14.x
Node version 18.19.1

Reproducer

No response

Angular version

17.3.5

PrimeNG version

17.13.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18.19.1

Browser(s)

All

Steps to reproduce the behavior

Open a dialog panel (p-dialog) containing an Editor, it dosent work and don't have styles.

Expected behavior

No response

@aaron-cardenas aaron-cardenas added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 20, 2024
@armingdev
Copy link

I hope this will be fixed soon. I'm blocked on the project because of this issue. #14931

@aaron-cardenas aaron-cardenas changed the title Component: Editor Component: Editor isn't functional within dialogs Apr 22, 2024
@nejat-njonjo
Copy link
Contributor

You should put the editor inside if block, so it gets initialized on when the visible state changes, like below. I use it like this and it works jus fine.

<p-dialog
  header="some header"
  [modal]="true"
  [(visible)]="visible"
  [style]="{ width: '50rem' }"
  [breakpoints]="{ '1199px': '75vw', '575px': '90vw' }"
  [maximizable]="true"
>
    @if (visible) {
     <p-editor></p-editor>
    }
</p-dialog>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible
Projects
None yet
Development

No branches or pull requests

3 participants