Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component: Paginator aria replacement problem #15413

Closed
Deeadline opened this issue Apr 30, 2024 · 0 comments · Fixed by #15414
Closed

Component: Paginator aria replacement problem #15413

Deeadline opened this issue Apr 30, 2024 · 0 comments · Fixed by #15414
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
17.16.0

Comments

@Deeadline
Copy link
Contributor

Describe the bug

When I started working with paginator component using i18n. I've added custom aria text to "pageLabel" in my language. Unfortunately someone did "replacement" method and replaced "{page}" text to "Page {page}" when this page in brackets is replaced with proper number. Because of it I have screen reader with "Something from my translation Page 1".

Environment

Just windows with node 18+, angular 17 and primeNG 17.15

Reproducer

https://github-qxuv1y.stackblitz.io

Angular version

17.3.0

PrimeNG version

17.15.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

18

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

When translation is: "My page {page}", screen reader should read it as "My page 1" instead of "My page Page 1"
@Deeadline Deeadline added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 30, 2024
@Deeadline Deeadline mentioned this issue Apr 30, 2024
Merged
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working LTS-16-PORTABLE Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 3, 2024
@cetincakiroglu cetincakiroglu added this to the 17.16.0 milestone May 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility Issue or pull request is related to WCAG or ARIA LTS-16-PORTABLE Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
17.16.0
Development

Successfully merging a pull request may close this issue.

Fix paginator getPageAriaLabel replacement Deeadline/primeng
2 participants
@Deeadline @cetincakiroglu