Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Unit Tests #15416

Closed
dobanisola-scottlogic opened this issue May 1, 2024 · 0 comments · Fixed by #15427
Closed

Broken Unit Tests #15416

dobanisola-scottlogic opened this issue May 1, 2024 · 0 comments · Fixed by #15427
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@dobanisola-scottlogic
Copy link
Contributor

dobanisola-scottlogic commented May 1, 2024

Describe the bug

When trying to run npm run test, we have the following compilation errors:

Error: src/app/components/picklist/picklist.spec.ts:253:18 - error TS2554: Expected 5-6 arguments, but got 4.

253 picklist.onItemClick(event, picklist.source[0], picklist.selectedItemsSource, callback);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/app/components/picklist/picklist.ts:922:88
922 onItemClick(event: Event | any, item: any, selectedItems: any[], listType: number, callback: EventEmitter, itemId?: string) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~
An argument for 'callback' was not provided.

\ Generating browser application bundles (phase: building)...01 05 2024 08:35:45.785:WARN [karma]: No captured browser, open http://localhost:9877/
01 05 2024 08:35:45.861:INFO [karma-server]: Karma v6.4.3 server started at http://localhost:9877/
01 05 2024 08:35:45.862:INFO [launcher]: Launching browsers Chrome with concurrency unlimited
01 05 2024 08:35:45.874:INFO [launcher]: Starting browser Chrome
√ Browser application bundle generation complete.

Error: src/app/components/picklist/picklist.spec.ts:253:18 - error TS2554: Expected 5-6 arguments, but got 4.

253 picklist.onItemClick(event, picklist.source[0], picklist.selectedItemsSource, callback);
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

src/app/components/picklist/picklist.ts:922:88
922 onItemClick(event: Event | any, item: any, selectedItems: any[], listType: number, callback: EventEmitter, itemId?: string) {
~~~~~~~~~~~~~~~~~~~~~~~~~~~
An argument for 'callback' was not provided.

01 05 2024 08:35:47.791:INFO [Chrome 123.0.0.0 (Windows 10)]: Connected on socket qxY6PvR5UzstF3J0AAAB with id 89045588
01 05 2024 08:35:48.844:WARN [web-server]: 404: /karma_webpack/main.js
Chrome 123.0.0.0 (Windows 10): Executed 0 of 0 SUCCESS (0.002 secs / 0 secs)
TOTAL: 0 SUCCESS

Environment

windows

Reproducer

No response

Angular version

17.3.6

PrimeNG version

17.15.0

Build / Runtime

Angular CLI App

Language

TypeScript

Node version (for AoT issues node --version)

v21.7.3

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response

@dobanisola-scottlogic dobanisola-scottlogic added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label May 1, 2024
@cetincakiroglu cetincakiroglu modified the milestones: 17.Future, 17.16.0 May 2, 2024
@cetincakiroglu cetincakiroglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels May 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants