Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom content support for TabMenu #3018

Closed
rachelbr opened this issue Jun 7, 2017 · 4 comments · Fixed by #6945
Closed

Custom content support for TabMenu #3018

rachelbr opened this issue Jun 7, 2017 · 4 comments · Fixed by #6945
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@rachelbr
Copy link

rachelbr commented Jun 7, 2017

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[ x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primeng/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=35

Plunkr Case (Bug Reports)

Current behavior
In TabMenu component there is no closeable ability for each tab
Expected behavior
I'm using prime 4 for angular
Could you add same functionality as tabview has to tabmenu? For example ability to close tabs
Following for #688
Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

ggPlease tell us about your environment:

windows

  • Angular version: 4.0.X
  • PrimeNG version: 4.0.X
  • Browser: [all | Chrome XX | Firefox XX | IE 11| Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

Chrome XX | IE 11

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
    TypeScript
  • Node (for AoT issues): node --version =
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Jun 8, 2017
@rachelbr
Copy link
Author

rachelbr commented Jun 8, 2017

mayby also nice to have customer option to decide for the active tab after closing
(nextTab if exist, previos ...)

@rfreydi
Copy link

rfreydi commented May 2, 2018

Up, no news if this feature will be added ?

@istephielicious
Copy link

Up, waiting for this feature to be implemented :)

@cagataycivici cagataycivici modified the milestone: 8.0.0 Dec 13, 2018
@cagataycivici cagataycivici removed the Type: New Feature Issue contains a new feature or new component request label Dec 13, 2018
@cagataycivici cagataycivici reopened this Dec 13, 2018
@cagataycivici cagataycivici changed the title TabMenu - close tab ability Custom content support for TabMenu Dec 13, 2018
@cagataycivici cagataycivici added this to the 7.0.2 milestone Dec 13, 2018
@cagataycivici cagataycivici self-assigned this Dec 13, 2018
@cagataycivici cagataycivici added the Type: New Feature Issue contains a new feature or new component request label Dec 13, 2018
@cagataycivici
Copy link
Member

If we add custom content support via templating then it would be easier so that an X icon can be added with the functionality you can bind.

@cagataycivici cagataycivici modified the milestones: 7.0.2, 7.0.3, 7.0.4 Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants