Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui-btn displayed as default text when there is no label set on buttons. #4252

Closed
PikaChokeMe opened this issue Oct 24, 2017 · 2 comments
Closed

Comments

@PikaChokeMe
Copy link
Contributor

PikaChokeMe commented Oct 24, 2017

labelElement.appendChild(document.createTextNode(this.label||'ui-btn'));

It would be nice to have the option to have an empty label, instead of all buttons just defaulting to have the text ui-btn when btn.label is falsey. I can think of a lot of situations in which an end user would prefer to just have a button that's just empty. I can think of almost 0 situations where the end user would prefer to have their button say ui-btn.

Edit: it is known by issue #1657 that you can hide the text by adding

.ui-button-text-only .ui-button-text{
    display: none !important;
}

but it seems like this isn't necessarily the best solution.

Edit edit: I have opened a pull request for this issue here.
#4254

@cagataycivici
Copy link
Member

cagataycivici commented Oct 25, 2017

I can't replicate the issue to begin with, create a plunkr please.

http://plnkr.co/edit/6q5v84DWolH6DeAdi70w?p=preview

@PikaChokeMe
Copy link
Contributor Author

PikaChokeMe commented Oct 25, 2017

http://plnkr.co/edit/dSx8dBkXUQJXWtZHIOvc?p=preview
Ok done.

Please reconsider my pull request.
#4254

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants