Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"in" doesn't properly filter value of null for Table #5735

Closed
Mysame opened this issue May 15, 2018 · 0 comments
Closed

"in" doesn't properly filter value of null for Table #5735

Mysame opened this issue May 15, 2018 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Mysame
Copy link
Contributor

Mysame commented May 15, 2018

[X] bug report => Search github for a similar issue or PR before submitting

Situation: Filtering a column field using a multiselect
car.owner = null;
filter list using multiSelect with value {label: 'empty', value: null}

List does not get properly filtered, even though car's owner (null) is in filtered values list ([null])

This due to a null check that seems out of place:

if (value === undefined || value === null) {

Example on stackblitz:
Try filtering on owner "None"
https://stackblitz.com/edit/github-6mznqy

Current behavior
"in" filter returns false when checking if

null

is in

[null]

Expected behavior
"in" filter returns true

@cagataycivici cagataycivici added this to the 7.0.4 milestone Dec 26, 2018
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Dec 26, 2018
@cagataycivici cagataycivici changed the title [Filter] "in" doesn't properly filter value of null "in" doesn't properly filter value of null for Table Dec 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants