Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turbo Table cannot filter empty values with "in" Filter #6808

Closed
JacobSiegle opened this issue Nov 1, 2018 · 3 comments
Closed

Turbo Table cannot filter empty values with "in" Filter #6808

JacobSiegle opened this issue Nov 1, 2018 · 3 comments
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@JacobSiegle
Copy link
Contributor

JacobSiegle commented Nov 1, 2018

NOTE: PR exists.

Current behavior
It's not possible to filter the table by null or undefined values.

Expected behavior
It should be able to filter empty rows.

Minimal reproduction of the problem with instructions
https://stackblitz.com/edit/github-2ovumv

@cagataycivici cagataycivici added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 1, 2019
@cagataycivici cagataycivici added this to the 8.1.0 milestone Oct 7, 2019
@cagataycivici cagataycivici modified the milestones: 8.1.0, 8.1.1 Oct 23, 2019
@yigitfindikli yigitfindikli modified the milestones: 8.1.1, 8.1.2 Oct 23, 2019
@cagataycivici cagataycivici removed this from the 8.1.2 milestone Jan 23, 2020
@lwestfall
Copy link
Contributor

Any chance that this will be looked at for near future release? I have a workaround in place for my app but it'd be nice to go back to the native "in" filter mode.

FilterUtils['in-fixed'] = (value, filters) => {
  if (filters === undefined || filters === null || filters.length === 0) {
      return true;
  }

  for (const filter of filters) {
      if (ObjectUtils.equals(value, filter)) {
          return true;
      }
  }

  return false;
};

@cagataycivici
Copy link
Member

Planned for 10.0.1.

@cagataycivici
Copy link
Member

We've discussed this internally as 10.0.1 should be released today, we postpone it to 10.0.2 as it requires more thinking. It has high priority so will be solved in the next one.

@cagataycivici cagataycivici modified the milestones: 10.0.1, 10.0.2 Sep 30, 2020
@cagataycivici cagataycivici modified the milestones: 10.0.2, 10.0.3, 10.1.0 Oct 1, 2020
@cagataycivici cagataycivici changed the title Turbo Table cannot filter empty values Turbo Table cannot filter empty values with "in" Filter Nov 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

5 participants