Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmationService does not let specify closeOnEscape #8790

Closed
dmytro-gokun opened this issue Apr 27, 2020 · 1 comment
Closed

ConfirmationService does not let specify closeOnEscape #8790

dmytro-gokun opened this issue Apr 27, 2020 · 1 comment
Assignees
@yigitfindikli
Labels
LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
11.0.0

Comments

@dmytro-gokun
Copy link

https://github.com/primefaces/primeng/blob/master/src/app/components/api/confirmation.ts

One would expect this to include 'closeOnEscape' as ConfirmDialog supports that: https://www.primefaces.org/primeng/showcase/#/confirmdialog
@dmytro-gokun
Copy link
Author

Any chance getting this implemented?

@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Nov 23, 2020
@yigitfindikli yigitfindikli self-assigned this Nov 23, 2020
@yigitfindikli yigitfindikli added this to the 11.0.1 milestone Nov 23, 2020
@yigitfindikli yigitfindikli added LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 and removed LTS-PORTABLE labels Dec 7, 2020
@cagataycivici cagataycivici changed the title ConformationService does not let specify closeOnEscape ConfirmationService does not let specify closeOnEscape Dec 8, 2020
@yigitfindikli yigitfindikli added the LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 label Dec 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yigitfindikli yigitfindikli

Labels
LTS-FIXED-9.2.1 Fixed in PrimeNG LTS 9.2.1 LTS-FIXED-10.0.6 Fixed in PrimeNG LTS 10.0.6 Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
11.0.0
Development

No branches or pull requests
2 participants
@dmytro-gokun @yigitfindikli