Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong behavior of Dialog.maskClickListener #9282

Closed
Kiramuxa opened this issue Sep 15, 2020 · 0 comments
Closed

wrong behavior of Dialog.maskClickListener #9282

Kiramuxa opened this issue Sep 15, 2020 · 0 comments
Assignees
Labels
LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@Kiramuxa
Copy link

this.maskClickListener = this.renderer.listen(this.wrapper, 'click', (event: any) => {

When you mousedown on the dialog and mouseup on the mask then the dialog is closed.

Example: I am trying to select the input text inside a dialog box and go slightly over the edge, then the dialog closes. It is necessary not only to set the listener on click, but to check whether the mousedown was made inside the dialog and if not, then block the event.

@cagataycivici cagataycivici added this to the 10.0.4 milestone Oct 12, 2020
@cagataycivici cagataycivici self-assigned this Oct 12, 2020
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 12, 2020
@cagataycivici cagataycivici modified the milestones: 10.0.4, 10.1.0 Oct 19, 2020
@yigitfindikli yigitfindikli added LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 labels Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
LTS-FIXED-9.2.0 Fixed in PrimeNG LTS 9.2.0 LTS-FIXED-10.0.5 Fixed in PrimeNG LTS 10.0.5 Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants