Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove functionality of locale property of Calendar #9504

Closed
cagataycivici opened this issue Nov 9, 2020 · 3 comments
Closed

Remove functionality of locale property of Calendar #9504

cagataycivici opened this issue Nov 9, 2020 · 3 comments
Assignees
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@cagataycivici
Copy link
Member

cagataycivici commented Nov 9, 2020

Instead of locale property labels like dayName should be received from the new i18n API. Also firstDayOfWeek should be a property of Calendar and dateFormat should always use the existing property.

@cagataycivici cagataycivici added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Type: Breaking Change Issue contains a breaking change related to a specific component labels Nov 9, 2020
@cagataycivici cagataycivici added this to the 10.1.0 milestone Nov 9, 2020
@cagataycivici cagataycivici self-assigned this Nov 9, 2020
@cagataycivici cagataycivici changed the title Use global i18n API for Calendar instead of locale property Remove functionality of locale property of Calendar Nov 9, 2020
@zmara
Copy link

zmara commented Feb 3, 2021

This issue should be opened again. Every modern UI library supports this type of localization (Kendo UI for example), because i18n is not the only way to set localizations. Changing locale during build time is not desired sometimes, look at Transloco, NgxTranslate and other libraries that change localization during runtime.

@Romulo-S
Copy link

Romulo-S commented May 13, 2022

Well i just see that is removed, there is no orientation or migration guide whatsoever how to solve that, now i just have my calendar broken. Awful..

@debbeca
Copy link

debbeca commented Aug 23, 2023

Well i just see that is removed, there is no orientation or migration guide whatsoever how to solve that, now i just have my calendar broken. Awful..

I totally agree
I've just spent two days trying to figure out what happened to my french calendar.
No migration guide or any deprecation mentioned in the documentation.
I had to spend hours on stackoverflow to figure out a way to make it work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants